This bounty is no longer available
Web3 DAO | Optimism Logo

op-service: cleanup logging service utils

Organization

Optimism

Deadline

N/A

Status

ENDED

INSTRUCTIONS

  • [ ] We should refactor the log flags to use cli.GenericFlag, which can then validate the flag value during flag-parsing time, instead of requiring config.Check()
  • [ ] The log writes to os.Stdout but should be writing to app.Writer, so we can test the CLI better, by running the urfave app commands and outputting into a buffer/checker.
  • [ ] Remove side-effects: The local logger config affects the global logger: this is undocumented/bad side-effect behavior. NewLogger should not touch log.Root().
  • [ ] Log-level should be runtime-configurable. We can have an admin_setLogLevel RPC endpoint to change it.
  • [ ] Move testlog package from op-node to op-service